From 010bd5fbe05befce230a952ceb3785bc5495d41b Mon Sep 17 00:00:00 2001 From: Andy Kolibri Vendetti Date: Wed, 30 Apr 2025 00:08:42 +0500 Subject: [PATCH] linter fixes --- internal/controller/nodetainterconfig_controller.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/internal/controller/nodetainterconfig_controller.go b/internal/controller/nodetainterconfig_controller.go index a135f8e..ed97159 100644 --- a/internal/controller/nodetainterconfig_controller.go +++ b/internal/controller/nodetainterconfig_controller.go @@ -126,15 +126,15 @@ func (r *NodeTainterConfigReconciler) Reconcile(ctx context.Context, req ctrl.Re // Converting map[string]string into map[string]corev1.Taint for convenience parsedRules, parseErrs := parseLabelRulesFromSpec(specLabelRules) if len(parseErrs) > 0 { - errMsg := fmt.Sprintf("Invalid rules found in NodeTainterConfig %s: %v", config.Name, parseErrs) - log.Error(fmt.Errorf(errMsg), "Rule parsing failed") - r.Recorder.Eventf(&config, corev1.EventTypeWarning, "InvalidConfig", errMsg) - _ = r.updateCRDStatus(ctx, &config, metav1.ConditionFalse, ConditionReasonConfigParsingError, errMsg) - _ = r.updateNodeTaintStatus(ctx, &node, nil, errMsg) + parsingError := fmt.Errorf("invalid rules found in NodeTainterConfig %s: %v", config.Name, parseErrs) + log.Error(parsingError, "Rule parsing failed", "configName", config.Name, "parsingErrors", parseErrs) + r.Recorder.Eventf(&config, corev1.EventTypeWarning, "InvalidConfig", parsingError.Error()) + _ = r.updateCRDStatus(ctx, &config, metav1.ConditionFalse, ConditionReasonConfigParsingError, parsingError.Error()) + _ = r.updateNodeTaintStatus(ctx, &node, nil, parsingError.Error()) return ctrl.Result{}, nil } - //log.V(1).Info("Parsed taint rules from CRD", "rulesCount", len(parsedRules)) + // log.V(1).Info("Parsed taint rules from CRD", "rulesCount", len(parsedRules)) // 4. Define desired Taints for THAT Node desiredTaints := calculateDesiredTaints(node.Labels, parsedRules)