andy/operator
Archived
1
1
Fork 0
Code Pull Requests Actions Activity

linter fixes
All checks were successful
Lint / Run on Ubuntu (push) Successful in 21s
Details
Tests / Run on Ubuntu (push) Successful in 26s
Details
Lint / Run on Ubuntu (pull_request) Successful in 20s
Details
Tests / Run on Ubuntu (pull_request) Successful in 50s
Details

Browse Source
This commit is contained in:
Andy Kolibri Vendetti
2025-05-01 19:39:58 +05:00
parent 23b333c07d
commit 2f05069e01
2 changed files with 17 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/main.go
View File

@@ -204,8 +204,8 @@ func main() {
}
if err = (&controller.NodeTainterConfigReconciler{
Client: mgr.GetClient(),
Scheme: mgr.GetScheme(),
Client: mgr.GetClient(),
Scheme: mgr.GetScheme(),
Recorder: mgr.GetEventRecorderFor("nodetainter-controller"),
}).SetupWithManager(mgr); err != nil {
setupLog.Error(err, "unable to create controller", "controller", "NodeTainterConfig")

22
internal/controller/deploymentdefaults_controller.go
View File

@@ -80,15 +80,23 @@ func (r *DeploymentDefaultsReconciler) Reconcile(ctx context.Context, req ctrl.R
defaultMemLim, errMemLim := parseQuantity(defaults.MemoryLimit)
var parseErrors []string
if errCPUReq != nil { parseErrors = append(parseErrors, fmt.Sprintf("CPURequest: %v", errCPUReq)) }
if errMemReq != nil { parseErrors = append(parseErrors, fmt.Sprintf("MemoryRequest: %v", errMemReq)) }
if errCPULim != nil { parseErrors = append(parseErrors, fmt.Sprintf("CPULimit: %v", errCPULim)) }
if errMemLim != nil { parseErrors = append(parseErrors, fmt.Sprintf("MemoryLimit: %v", errMemLim)) }
if errCPUReq != nil {
parseErrors = append(parseErrors, fmt.Sprintf("CPURequest: %v", errCPUReq))
}
if errMemReq != nil {
parseErrors = append(parseErrors, fmt.Sprintf("MemoryRequest: %v", errMemReq))
}
if errCPULim != nil {
parseErrors = append(parseErrors, fmt.Sprintf("CPULimit: %v", errCPULim))
}
if errMemLim != nil {
parseErrors = append(parseErrors, fmt.Sprintf("MemoryLimit: %v", errMemLim))
}
if len(parseErrors) > 0 {
errMsg := fmt.Sprintf("Invalid resource quantity format in NodeTainterConfig %s: %s", config.Name, strings.Join(parseErrors, "; "))
log.Error(fmt.Errorf(errMsg), "Default resource parsing failed")
r.Recorder.Eventf(&deployment, corev1.EventTypeWarning, "ConfigError", "Invalid defaults in config %s: %s", config.Name, strings.Join(parseErrors, "; "))
parsingError := fmt.Errorf("invalid resource quantity format in NodeTainterConfig %s: %s", config.Name, strings.Join(parseErrors, "; "))
log.Error(parsingError, "Default resource parsing failed", "configName", config.Name, "parsingErrors", parseErrors)
r.Recorder.Eventf(&deployment, corev1.EventTypeWarning, "ConfigError", parsingError.Error())
return ctrl.Result{}, nil
}